Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new filters for other collections #70

Merged
merged 46 commits into from
Aug 9, 2024
Merged

Add new filters for other collections #70

merged 46 commits into from
Aug 9, 2024

Conversation

brauliorivas
Copy link
Member

BEGINRELEASENOTES

  • Following GSoC tasks, we need to add more filters for other types of collections. That's why, depending on the view, filters will be added according to the collections in that view.
  • However, when first developing filters, I didn't take that well into account to allow for more filters. I think that the current code for filters is tangled and hard to follow. So I'm making it easier to understand and rewrite that part.
  • The goal is to add filters for all the collections that eede currently supports.

ENDRELEASENOTES
Currently, there are a few bugs when filtering objects in https://key4hep.github.io/eede/main/index.html because of #65. For example, when applying filters, the screen doesn't scroll to the new filtered objects. I'll also fix those bugs, and solve #53 because now is the moment.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-09 15:28 UTC

@tmadlener
Copy link
Contributor

I suppose since this is still WIP not everything is supposed to be working fully yet. I will just leave a few things that I have found so far (which you probably already know):

  • The css of the filter box seems to no longer be working properly. The input boxes for the ranges are no longer aligned
  • The mapping of bit number and bit name has not yet been adapted to work with the reversed direction of the SimStatusBitFieldDisplayValues mapping
  • I am not sure if you currently keep the filters/mcparticles.js around to keep things working or if it can be removed already now, since it will live in filters/collections/mcparticles.js after this PR

From my testing it looks like the re-arranging of the filtered objects seems to be working now, but it's hard to say from my testfile which is a bit too large to visually grok this.

@brauliorivas
Copy link
Member Author

brauliorivas commented Jul 31, 2024 •
edited
Loading

  • I am not sure if you currently keep the filters/mcparticles.js around to keep things working or if it can be removed already now, since it will live in filters/collections/mcparticles.js after this PR

Yes, I'll keep it to guide myself while re-doing filters. Then, I'll remove it.

This was referenced Aug 2, 2024
Closed
Closed
@tmadlener
Copy link
Contributor

A few more comments from my side that are related to this PR. I have opened a few issues which I think are unrelated to changes in this PR and it should be possible to deal with them after this has been finished.

  • The Filter "window" / overlay is now visible on the landing page. Is it possible to remove it again from there?
    image
  • The MCParticle filters seem to be partially broken (?). I can filter e.g. on momentum, but if I try to filter on the generator or simulation status nothing is happening (unless I am too impatient, but I think this was once almost instantaneous, which is why I am now wondering).
  • I don't think this PR triggered this, but I can't seem to easily reproduce this on the main branch: I managed to get MCParticle overlays getting stuck
    image
    Given that I do not really now how I got to this state on this PR preview, and I also can't reproduce it anywhere, consider this mainly as "we have seen this before once", but don't really act on this until we have a more solid reproducer.

@brauliorivas brauliorivas linked an issue Aug 3, 2024 that may be closed by this pull request
Make it possible to invert a filter selection #72
Closed
@brauliorivas brauliorivas linked an issue Aug 3, 2024 that may be closed by this pull request
View selection panel should be collapsed by default #71
Closed
@kjvbrt kjvbrt merged commit 4ba0b9b into key4hep:main Aug 9, 2024
2 checks passed
@brauliorivas brauliorivas mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjvbrt kjvbrt Awaiting requested review from kjvbrt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@brauliorivas @tmadlener @kjvbrt